OCPBUGS-74241: Add null checks to CRB subject #15943

logonoff · 2026-01-22T14:05:21Z

Summary by CodeRabbit

Bug Fixes
- Enhanced stability of binding actions by implementing defensive checks that prevent runtime errors when subject data is not available, ensuring reliable operation in edge cases.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

openshift-ci-robot · 2026-01-22T14:05:28Z

@logonoff: This pull request references Jira Issue OCPBUGS-74241, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-01-22T14:06:06Z

/jira refresh
/cherry-pick release-4.21

/assign @rhamilto

openshift-cherrypick-robot · 2026-01-22T14:06:10Z

@logonoff: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/jira refresh
/cherry-pick release-4.21

/assign @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2026-01-22T14:06:16Z

@logonoff: This pull request references Jira Issue OCPBUGS-74241, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh
/cherry-pick release-4.21

/assign @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-22T14:06:17Z

@logonoff: This pull request references Jira Issue OCPBUGS-74241, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Summary by CodeRabbit

Bug Fixes

Enhanced stability of binding actions by implementing defensive checks that prevent runtime errors when subject data is not available, ensuring reliable operation in edge cases.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-01-22T14:07:17Z

📝 Walkthrough

Walkthrough

The pull request adds optional safety guards to subject data access within the useBindingActions hook. The subject parameter now defaults to an empty array when absent, and all references to subject properties transition from direct access (subject.name, subject.kind) to optional chaining (subject?.name, subject?.kind). This includes updates to dependency arrays in memoized logic, conditional guards for User/Group action generation, and impersonation/accessReview operations. The changes defensively handle scenarios where subject data may be undefined at runtime.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding null checks to ClusterRoleBinding subject handling, which aligns with the changeset's focus on introducing optional safety guards and optional chaining for subject data.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

logonoff · 2026-01-22T14:08:24Z

went into cluster-admin role binding, hovered over actions menu and did not see runtime error. clicking all the actions work as expected

/verified by @logonoff

openshift-ci-robot · 2026-01-22T14:08:39Z

@logonoff: This PR has been marked as verified by @logonoff.

Details

In response to this:

went into cluster-admin role binding, hovered over actions menu and did not see runtime error. clicking all the actions work as expected

/verified by @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhamilto · 2026-01-22T15:44:44Z

/lgtm

openshift-ci · 2026-01-22T15:54:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [logonoff,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-01-22T16:02:04Z

/retest-required

Remaining retests: 0 against base HEAD b04aada and 2 for PR HEAD c22bf3e in total

logonoff · 2026-01-22T16:22:15Z

/verified cancel
/assign @yapei

openshift-ci-robot · 2026-01-22T16:22:20Z

@logonoff: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified cancel
/assign @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-01-22T16:25:14Z

/verified cancel

openshift-ci-robot · 2026-01-22T16:25:18Z

@logonoff: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

/verified cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

logonoff · 2026-01-22T16:25:34Z

/verified remove

openshift-ci-robot · 2026-01-22T16:25:48Z

@logonoff: The verified label has been removed.

Details

In response to this:

/verified remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-01-22T19:41:03Z

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

OCPBUGS-74241: Add null checks to CRB subject

c22bf3e

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2026

openshift-ci bot requested review from TheRealJon and rhamilto January 22, 2026 14:05

openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2026

openshift-ci bot assigned rhamilto Jan 22, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2026

openshift-ci bot requested a review from yapei January 22, 2026 14:06

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026

openshift-ci bot assigned yapei Jan 22, 2026

openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026

OCPBUGS-74241: Add null checks to CRB subject #15943

Are you sure you want to change the base?

OCPBUGS-74241: Add null checks to CRB subject #15943

Conversation

logonoff commented Jan 22, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

logonoff commented Jan 22, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 22, 2026

Walkthrough

Review ran into problems

Uh oh!

logonoff commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

rhamilto commented Jan 22, 2026

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

logonoff commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

logonoff commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

logonoff commented Jan 22, 2026

Uh oh!

openshift-ci-robot commented Jan 22, 2026

Uh oh!

openshift-ci bot commented Jan 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

logonoff commented Jan 22, 2026 •

edited by coderabbitai bot

Loading